This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPodymov
changed the title
Migration to Swift 4.2/Xcode 10
Migrating to Swift 4.2/Xcode 10
Oct 13, 2018
Hi Roman, thank you for your contribution! @dzindra please take a look. |
dzindra
suggested changes
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Roman, thanks for your pull request. I checked it and commented on some changes you made. Also when I try to compile code, it fails on UIControlState type changed in Swift 4.2. Please address the issues and I will merge your PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening.
Thank you for this library, it looks very interesting.
I'd like to add support of Swift 4.2 for the localizenib-ios and here is what I did:
swiftlint autocorrect
;