Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using environment variables for backend secrets #912

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Allow using environment variables for backend secrets #912

merged 1 commit into from
Feb 6, 2025

Conversation

Adphi
Copy link
Contributor

@Adphi Adphi commented Jan 28, 2025

No description provided.

@Adphi
backend secrets: read with environment override
dcda098 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13017000083

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 63.901%
Files with Coverage Reduction New Missed Lines %
grpc_client.go 1 79.4%
grpc_remote_client.go 2 75.57%
client.go 2 73.41%
dns_monitor.go 4 94.12%
Totals Coverage Status
Change from base Build 13011289482: -0.05%
Covered Lines: 11878
Relevant Lines: 18588
💛 - Coveralls

@fancycode fancycode merged commit 45ef6fd into strukturag:master Feb 6, 2025
17 of 19 checks passed
@fancycode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adphi @coveralls @fancycode