AMD Support

[lboynton]

I created a pull request in the old repository for AMD support (metajack/strophejs#99). Is this something that people are interested in? I can rebase my changes on the current master if so and submit a PR.

[alexhancock]

@lboynton I would be interested in this.

[spiderworm]

Absolutely interested here as well.

[isfarax]

Definately, I am using stropheAMD already but would like this guaranteed for new versions. thanks in advance.

[karellm]

Please add this!

[isfarax]

Hi all, is there a proper support group for stropheAMD or is everybody waiting for everybody else?? cos I've seen some scattered around and it would be nice if somebody could take charge to look after stropheAMD as its gaining more interest.

[lboynton]

Yes, I've been meaning to look at rebasing my old changes onto master. Hopefully I'll get some time this or next month. However, last time there didn't seem to be much interest in getting it merged.

[isfarax]

Hi, sorry its been a long time.

could you direct me to the link of the stropheAMD?

there is a new version (1.1.3.), do you think it is possible to get it working with AMD??

[jcbrand]

I tried to rebase @lboynton's changes but found it easier to rather just add AMD support from scratch. My changes are now in the amd-merge branch.

I've tested both the AMD and non-AMD usecases with converse.js and all looks fine. All tests also pass.

After @Gordin has released version 1.1.4 I'll merge that branch with master.

[Gordin]

@jcbrand If this does not break compatibility with anything I'd like to just include this in the next release. Is there any reason not to do this? (I've never used AMD)

[jcbrand]

@Gordin Suits me fine if we include it in the next release. It's still backwards compatible and my main reason for waiting was just to be conservative.

[jcbrand]

@Gordin I've submitted a pull request. Please merge if you're happy with it.

[isfarax]

Hi Guys,

This is great stuff. Thank you so much. I shall check it out, good idea to release it with the new version 1.1.4.

[Gordin]

This is now included in the current 1.2.0 release.