Globalize #14
Open
Globalize #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/sl-svc-install.js
Outdated
Contributor
There was a problem hiding this comment.
I don't see this call signature for t() documented. Why is a function being passed in? Won't this cause the function source to be appended to the output?
Author
There was a problem hiding this comment.
.txt contents is loaded as one message with the key being the file name. g.t('sl-serv-ce-install.txt, ...) is equivalent to g.t('usage: {0} [options] {{-- }}\n\nOptions:\n{{-h,--help}} ....
Author
|
@sl-node test please |
Author
|
All the three dependants, strong-nginx-controller, strong-executor, and strong-pm failed. |
Setogit
force-pushed
the
globalize
branch
3 times, most recently
from
410c386 to
447b116
Compare
Author
|
This requires strongloop/strong-globalize#5 |
Contributor
There was a problem hiding this comment.
this introduces a bug, please return g.log(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect to strongloop-internal/scrum-nodeops#1157