Globalize #41
Open
Globalize #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
Contributor
|
@Setogit you did a search-n-replace for console, but you don't protect words that must not be translated. Won't that mean that the translated output is wrong? |
Author
|
Added some more {{ }} translation protection. |
Author
|
@sl-node test please |
Author
|
@sl-note test please |
Author
|
dependant: strong-pm build failed. Two other dependants strong-arc and strongloop succeeded. |
Author
|
This requires strongloop/strong-globalize#5 |
Contributor
There was a problem hiding this comment.
please keep requires alphabetized
Contributor
|
LGTM _don't merge until strong-globalize is published_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect to strongloop-internal/scrum-nodeops#1157