Temporarily disable Karma tests on Windows CI #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are observing frequent test failures on Windows CI, where PhantomJS cannot start because there are no free handles available. Finding and fixing the process leaking handles is non-trivial and will take long time. This commit disables Karma tests on Windows CI machines to prevent build failures that we are ignoring anyways.
bajtos
force-pushed
the
fix/windows-ci
branch
from
c31eda5 to
0cd157c
Compare
superkhau
approved these changes
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are observing frequent test failures on Windows CI, where PhantomJS cannot start because there are no free handles available. Finding and fixing the process leaking handles is non-trivial and will take long time.
This commit disables Karma tests on Windows CI machines to prevent build failures that we are ignoring anyways.
See also https://github.com/strongloop-internal/scrum-loopback/issues/1052
@superkhau please review
cc @rmg