[SEMVER-MAJOR] Fix remoting strong-error-handler #2375
Conversation
davidcheung
force-pushed
the
fix-remoting-strongerrorhandler
branch
from
ff45b08 to
6db3fe3
Compare
|
@bajtos PTAL |
test/app.test.js
Outdated
| var app, db; | ||
| beforeEach(function() { | ||
| app = loopback(); | ||
| app.set('remoting', { errorHandler: { debug: false, log: false }}); |
There was a problem hiding this comment.
I think it's better to set debug:true in tests, so that we get more details in error messages. Thoughts?
There was a problem hiding this comment.
agreed, not sure what i was thinking
|
@davidcheung the patch looks mostly good, my main concern is the inconsistency in |
|
@bajtos PTAL again please |
|
@davidcheung the code changes LGTM, but the CI is all red. Please investigate. If it's something trivial, then feel free to land this without further reviews. Also, could you please capture somewhere in release notes that by default, LoopBack 3.0-powered applications will log failed requests to stderr? We didn't log errors in 2.x, I think it may surprise people when they discover for the first time. The section in release notes should include instructions how to disable these log messages (revert back to 2.x behavior). |
|
@bajtos i will retrigger ci once strong-remoting lands, which should pass all the tests, the change in this PR is disabling stacktrace on new |
davidcheung
force-pushed
the
fix-remoting-strongerrorhandler
branch
from
c1a1088 to
d8113c8
Compare
Fix rest-adapter related test case switching to strong-error-handler Only affect the test-cases calling rest methods
davidcheung
force-pushed
the
fix-remoting-strongerrorhandler
branch
from
d8113c8 to
ddb5327
Compare
|
@slnode test please |
3 participants
connect to https://github.com/strongloop-internal/scrum-loopback/issues/852
addresses test cases failing and stacktrace showing up on
npm testshould land with strongloop/strong-remoting#302