Add globalization #299
Merged
Add globalization #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
0candy
force-pushed
the
initial_glob
branch
3 times, most recently
from
22e634e to
0b3bf18
Compare
0candy
force-pushed
the
initial_glob
branch
2 times, most recently
from
3adb844 to
1eb6839
Compare
Contributor
Author
|
@jannyHou or @superkhau PTAL. Thanks. |
| return cb( | ||
| new Error('Cannot connect to the data source.' + | ||
| ' Ensure the configuration is valid and the connector is installed.')); | ||
| new Error(g.t('Cannot connect to the data source.' + |
Contributor
|
@0candy Only some reminders that change |
0candy
force-pushed
the
initial_glob
branch
2 times, most recently
from
9bdc5d5 to
ade210a
Compare
| }, | ||
| function createUser(next) { | ||
| console.log('Creating user %s with password %s', USER, PASSWORD); | ||
| console.log(g.f('Creating user %s with password %s', USER, PASSWORD)); |
Contributor
There was a problem hiding this comment.
I see inconsistency between using console.log or g.log
Contributor
There was a problem hiding this comment.
👍 We should allow either but probably recommend g.log in globalization.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strongloop/loopback#2422