Skip to content

Create Issue and PR Templates #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Create Issue and PR Templates #277

merged 2 commits into from
Aug 16, 2017

Conversation

ssh24
Copy link

@ssh24 ssh24 commented Aug 15, 2017

Update Issue and PR Templates

@ssh24 ssh24 requested a review from bajtos as a code owner August 15, 2017 20:04
@ssh24 ssh24 added the #review label Aug 15, 2017
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits, edit PR description and commit message to say "update" instead of "create".

@ssh24 ssh24 merged commit 44a1ef8 into master Aug 16, 2017
@ssh24 ssh24 deleted the create-issue-pr-templates branch August 16, 2017 14:44
@ssh24 ssh24 removed the #review label Aug 16, 2017
@ssh24 ssh24 self-assigned this Aug 16, 2017
@ssh24 ssh24 added this to the Sprint 42 - Apex milestone Aug 16, 2017
rashmihunt added a commit that referenced this pull request Aug 22, 2017
 * Address code review comment (rashmihunt)
 * updateOnly property (rashmihunt)
 * Update Issue and PR Templates (#277) (Sakib Hasan)
 * Update translated strings Q3 2017 (Allen Boone)
 * update translation file (Diana Lau)
 * Add CODEOWNER file (Diana Lau)
 * Replicate new issue_template from loopback (Siddhi Pai)
 * Replicate issue_template from loopback repo (Siddhi Pai)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants