Globalize loopback-angular-sdk-cli #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
Contributor
Author
|
@slnode test please |
Member
That's fine, I agree it's better to have a Just make sure the "scripts" entry in package.json on line 6 keeps working after rename. When users install via ATM, we have "lb-ng": "bin/lb-ng"I don't know if "lb-ng": "bin/lb-ng.js" |
Contributor
Author
|
@0candy PTAL |
| var generator = require('loopback-sdk-angular'); | ||
| var SG = require('strong-globalize'); | ||
| SG.SetRootDir(path.resolve(__dirname, '..')); | ||
| var g = SG(); |
Contributor
There was a problem hiding this comment.
This should be at the beginning of the file.
Contributor
|
Changes LGTM. Please squash before merge. |
note that `lb-ng` is changed to `lb-ng.js` because slt-globalize checks files based on file extension
Contributor
Author
|
@slnode test please |
1 similar comment
Contributor
Author
|
@slnode test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bajtos stl-globalize uses file extensions to determine what gets globalized, I have updated the name to
lb-ng.js(fromlb-ng), is there any particular advantage or reasons we shouldn't change it? I can see it being more likely to be skipped by lint as well.@0candy PTAL
/cc @Setogit
related to strongloop/loopback#2422