Add FCM support with addNotification in node-gcm 1.4.4 #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Member
Author
|
Added tests to prevent regressions as per request in #141. cc @superkhau |
superkhau
approved these changes
Feb 7, 2017
Contributor
|
@zbarbuto TY for following up with a test to prevent regressions. 👍 |
Contributor
|
@slnode test please |
Member
Author
|
@superkhau Anything else I can do to help get this merged? Does someone else need to review? |
superkhau
approved these changes
Feb 14, 2017
Contributor
|
@zbarbuto Nope, it's LGTM now. TY for the contribution. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notifications aren't sent to the new FCM system with the latest version of
node-gcm. This uses theaddNotification()method to add the expected notification properties to the message to be sent.The properties used are
messageFromfor the title andalertfor the body as this makes it fully compatible with the existing docs on notifications (ie. the result on the device will be the same on both iOS and Android)Related issues
Checklist
guide