Skip to content

Add globalization #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
superkhau merged 1 commit into from
Aug 4, 2016
Merged

Add globalization #170

superkhau merged 1 commit into from
Aug 4, 2016

Conversation

@superkhau
Copy link
Contributor

@superkhau superkhau commented Jul 22, 2016

@0candy 0candy mentioned this pull request Jul 22, 2016
Closed
63 tasks
@superkhau
Copy link
Contributor Author

superkhau commented Jul 22, 2016

@slnode test please

@0candy 0candy removed their assignment Jul 22, 2016
0candy
0candy reviewed Jul 22, 2016
View reviewed changes
example/hidden.js Outdated
explorer(app, { basePath: apiPath });
app.use(apiPath, loopback.rest());
console.log('Explorer mounted at localhost:' + port + '/explorer');
console.log(g.f('Explorer mounted at localhost:%s/explorer', port));
Copy link
Contributor

@0candy 0candy Jul 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add {{}} around the url

@superkhau superkhau assigned 0candy and unassigned superkhau Jul 23, 2016
@superkhau
Copy link
Contributor Author

superkhau commented Jul 23, 2016

@0candy Updated, review again pls.

0candy
0candy reviewed Jul 25, 2016
View reviewed changes
example/hidden.js Outdated
explorer(app, { basePath: apiPath });
app.use(apiPath, loopback.rest());
console.log('Explorer mounted at localhost:' + port + '/explorer');
console.log(g.f('Explorer mounted at {{localhost:%s/explorer}}', port));
Copy link
Contributor

@0candy 0candy Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run slt-globalize -e again for intl/en/messages.json to get updated with the brackets change.

Copy link
Contributor

@richardpringle richardpringle Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Explorer should be translated, should it?

@superkhau
Copy link
Contributor Author

superkhau commented Jul 25, 2016

@0candy Updated, PTAL again.

@0candy
Copy link
Contributor

0candy commented Jul 26, 2016

Please make sure var SG = require('strong-globalize'); is at the beginning of the file.

@0candy 0candy assigned superkhau and unassigned 0candy Jul 27, 2016
@superkhau superkhau force-pushed the globalization branch 3 times, most recently from 98fc894 to 8c18d0b Compare July 27, 2016 22:46
@superkhau
Copy link
Contributor Author

superkhau commented Jul 27, 2016

@slnode test please

@superkhau superkhau force-pushed the globalization branch 2 times, most recently from 4e1f0f8 to 72cde0d Compare July 28, 2016 20:13
@superkhau
Copy link
Contributor Author

superkhau commented Jul 28, 2016

@Amir-61 @loay PTAL

@superkhau
Copy link
Contributor Author

superkhau commented Jul 28, 2016 •
edited
Loading

Actually sorry @Amir-61 @loay, I looked up the wrong repo owners.

@gunjpan @richardpringle PTAL instead. 💪 Updated using latest conventions.

richardpringle
richardpringle reviewed Jul 29, 2016
View reviewed changes
example/simple.js Outdated
explorer(app, { basePath: apiPath });
app.use(apiPath, loopback.rest());
console.log('Explorer mounted at http://localhost:' + port + '/explorer');
console.log(g.f('Explorer mounted at {{http://localhost:%s/explorer}}', port));
Copy link
Contributor

@richardpringle richardpringle Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as before,

I think it should be {{Explorer}}.

@richardpringle
Copy link
Contributor

richardpringle commented Jul 29, 2016

@superkhau, left a couple comments.

@superkhau
Copy link
Contributor Author

superkhau commented Jul 30, 2016

@gunjpan @richardpringle Fixed up based on feedback. PTAL again.

richardpringle
richardpringle reviewed Aug 3, 2016
View reviewed changes
example/hidden.js
explorer(app, { basePath: apiPath });
app.use(apiPath, loopback.rest());
console.log('Explorer mounted at localhost:' + port + '/explorer');
g.log('{{Explorer}} mounted at {{localhost:%s/explorer}}', port);
Copy link
Contributor

@richardpringle richardpringle Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0candy, it was said somewhere that words with an uppercase letter to not get translated, does that include words at the beginning of a sentence?

Copy link
Contributor

@0candy 0candy Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardpringle It is only for words with ALL caps. ie. API that don't get translated or any words you put within the double brace. In your case, both Explorer and the url will not be translated.

@superkhau
Copy link
Contributor Author

superkhau commented Aug 3, 2016

@richardpringle Please leave LGTM next time. I assume all the thumbs ups means 🚢?

@superkhau superkhau merged commit 4ebd792 into master Aug 4, 2016
@superkhau superkhau deleted the globalization branch August 4, 2016 07:52
@superkhau superkhau removed the #review label Aug 4, 2016
@richardpringle richardpringle removed their assignment Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@superkhau superkhau

@gunjpan gunjpan

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@superkhau @0candy @richardpringle @gunjpan @simonhoibm