Skip to content

Format breaking change warning to improve discoverability #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xavdid-stripe merged 2 commits into from
Dec 9, 2025
Merged

Format breaking change warning to improve discoverability #1741

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309ff75
Format breaking change warning to improve discoverability
peterxjang-stripe Dec 4, 2025
321612f
Merge branch 'master' into format-breaking-change-message
xavdid-stripe Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/stripe/stripe_object.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,17 @@ class << self; self; end
# see also: https://go/j/DEVSDK-2835
if is_a?(Invoice) && name == :payment_intent
raise NoMethodError,
"The 'payment_intent' attribute is no longer available on Invoice objects. " \
"See the docs for more details: https://docs.stripe.com/changelog/basil/2025-03-31/" \
"add-support-for-multiple-partial-payments-on-invoices#why-is-this-a-breaking-change"
"\n\n" \
"-----------------\n" \
" BREAKING CHANGE \n" \
"-----------------\n" \
"The 'payment_intent' attribute is no longer available on Invoice objects.\n\n" \
"See the docs for more details:\n" \
"https://docs.stripe.com/changelog/basil/2025-03-31/" \
"add-support-for-multiple-partial-payments-on-invoices#why-is-this-a-breaking-change\n" \
"-----------------\n" \
" BREAKING CHANGE \n" \
"-----------------" \
end

# If we notice the accessed name of our set of transient values we can
Expand Down