Support events in Financial Connections #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
3 times, most recently
from
1aac014 to
53df471
Compare
tillh-stripe
commented
Feb 7, 2025
Comment on lines
+41
to
+46
| if (stripeSdkModule != null && stripeSdkModule.eventListenerCount > 0) { | ||
| FinancialConnections.setEventListener { event -> | ||
| val params = mapFromFinancialConnectionsEvent(event) | ||
| stripeSdkModule.sendEvent(context, "onFinancialConnectionsEvent", params) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a “best guess” approach, since I don’t see a way for us to reliably track if a listener is registered for onFinancialConnectionsEvent.
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
from
53df471 to
35f09f0
Compare
tillh-stripe
commented
Feb 7, 2025
| @@ -84,7 +84,7 @@ type NativeStripeSdkType = { | |||
| collectBankAccount( | |||
| isPaymentIntent: boolean, | |||
| clientSecret: string, | |||
| params: PaymentMethod.CollectBankAccountParams | |||
| params: Omit<PaymentMethod.CollectBankAccountParams, 'onEvent'> | |||
There was a problem hiding this comment.
No need to pass onEvent around.
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
from
f0a1c5d to
f1400cc
Compare
charliecruzan-stripe
requested changes
Feb 11, 2025
android/src/main/java/com/reactnativestripesdk/CollectBankAccountLauncherFragment.kt
Show resolved
Hide resolved
| super.onCreate(savedInstanceState) | ||
|
|
||
| val stripeSdkModule: StripeSdkModule? = context.getNativeModule(StripeSdkModule::class.java) | ||
| if (stripeSdkModule != null && stripeSdkModule.eventListenerCount > 0) { |
There was a problem hiding this comment.
same here, do something like this:
src/functions.ts
Outdated
Comment on lines
471
to
473
| const subscription = | ||
| params.onEvent && | ||
| eventEmitter.addListener('onFinancialConnectionsEvent', params.onEvent); |
There was a problem hiding this comment.
we have an existing paradigm for this in this file:
stripe-react-native/src/functions.ts
Line 357 in f1400cc
I think it should be fine with this setup overall, but i'd rather keep it consistent with the other subscriptions we have
There was a problem hiding this comment.
Gotcha, will take a stab at it!
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
2 times, most recently
from
ab5f22a to
a06c6f1
Compare
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
from
a06c6f1 to
be9f011
Compare
tillh-stripe
force-pushed
the
tillh/try-to-fix-tests
branch
from
f67b577 to
34cc267
Compare
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
from
be9f011 to
8d8e12f
Compare
Use `financialConnectionsEventListener` instead of local subscriptions
tillh-stripe
force-pushed
the
tillh/fc-events-support
branch
from
8d8e12f to
89e93ec
Compare
charliecruzan-stripe
previously approved these changes
Feb 18, 2025
CHANGELOG.md
Outdated
|
|
||
| **Features** | ||
|
|
||
| - Added ability to pass an `onEvent` listener to Financial Connections methods via a `params` argument. |
There was a problem hiding this comment.
let's put a list of which methods, just to be explicit
charliecruzan-stripe
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for passing an
onEventhandler to Financial Connections methods, similar to the native Android and iOS SDKs.Motivation
MOBILE_APIREVIEW-117
Testing
Documentation
Select one: