Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate explicit nested resource class methods #1050

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add back decorators
  • Loading branch information
richardm-stripe committed Sep 14, 2023
commit 65c32b5dd88e1d79d90a1b30cf32f2988f72bb84
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
from stripe.api_resources.abstract import APIResource


# TODO(major): Remove this. It is no longer used except for "nested_resource_url" and "nested_resource_request",
# which are unnecessary ande deprecated.
def nested_resource_class_methods(
resource, path=None, operations=None, resource_plural=None
):
if resource_plural is None:
resource_plural = "%ss" % resource
if path is None:
path = resource_plural
if operations is None:
raise ValueError("operations list required")

def wrapper(cls):
def nested_resource_url(cls, id, nested_id=None):
Expand Down Expand Up @@ -54,6 +54,9 @@ def nested_resource_request(
cls, resource_request_method, classmethod(nested_resource_request)
)

if operations is None:
return cls

for operation in operations:
if operation == "create":

Expand Down
5 changes: 5 additions & 0 deletions stripe/api_resources/account.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.list_object import ListObject
from stripe.stripe_object import StripeObject
Expand All @@ -21,6 +22,10 @@
from stripe.api_resources.person import Person


@nested_resource_class_methods("capability")
@nested_resource_class_methods("external_account")
@nested_resource_class_methods("login_link")
@nested_resource_class_methods("person")
class Account(
CreateableAPIResource["Account"],
DeletableAPIResource["Account"],
Expand Down
6 changes: 5 additions & 1 deletion stripe/api_resources/application_fee.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
from __future__ import absolute_import, division, print_function

from stripe import util
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import (
ListableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.expandable_field import ExpandableField
from stripe.api_resources.list_object import ListObject
from typing import Optional
Expand All @@ -21,6 +24,7 @@
from stripe.api_resources.charge import Charge


@nested_resource_class_methods("refund")
class ApplicationFee(ListableAPIResource["ApplicationFee"]):
OBJECT_NAME = "application_fee"
account: ExpandableField["Account"]
Expand Down
2 changes: 2 additions & 0 deletions stripe/api_resources/credit_note.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
CreateableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.expandable_field import ExpandableField
from stripe.api_resources.list_object import ListObject
Expand All @@ -26,6 +27,7 @@
from stripe.api_resources.refund import Refund


@nested_resource_class_methods("line")
class CreditNote(
CreateableAPIResource["CreditNote"],
ListableAPIResource["CreditNote"],
Expand Down
5 changes: 5 additions & 0 deletions stripe/api_resources/customer.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
ListableAPIResource,
SearchableAPIResource,
UpdateableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.expandable_field import ExpandableField
from stripe.api_resources.list_object import ListObject
Expand All @@ -28,6 +29,10 @@
from stripe.api_resources.test_helpers.test_clock import TestClock


@nested_resource_class_methods("balance_transaction")
@nested_resource_class_methods("cash_balance_transaction")
@nested_resource_class_methods("source")
@nested_resource_class_methods("tax_id")
class Customer(
CreateableAPIResource["Customer"],
DeletableAPIResource["Customer"],
Expand Down
3 changes: 3 additions & 0 deletions stripe/api_resources/subscription_item.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.list_object import ListObject
from stripe.stripe_object import StripeObject
Expand All @@ -23,6 +24,8 @@
from stripe.api_resources.tax_rate import TaxRate


@nested_resource_class_methods("usage_record")
@nested_resource_class_methods("usage_record_summary")
class SubscriptionItem(
CreateableAPIResource["SubscriptionItem"],
DeletableAPIResource["SubscriptionItem"],
Expand Down
2 changes: 2 additions & 0 deletions stripe/api_resources/transfer.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
CreateableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
nested_resource_class_methods,
)
from stripe.api_resources.expandable_field import ExpandableField
from stripe.api_resources.list_object import ListObject
Expand All @@ -23,6 +24,7 @@
from stripe.api_resources.reversal import Reversal


@nested_resource_class_methods("reversal")
class Transfer(
CreateableAPIResource["Transfer"],
ListableAPIResource["Transfer"],
Expand Down