Another batch of PHP-CS-Fixer rule updates #872
Conversation
| @@ -1,6 +1,6 @@ | |||
| <?php | |||
|
|
|||
| require('../init.php'); | |||
| require '../init.php'; | |||
There was a problem hiding this comment.
whyyyyyyyyyyyyyyyy is this deemed better.
| @@ -150,8 +150,8 @@ private function serializeAdditionalOwners($legalEntity, $additionalOwners) | |||
| } | |||
|
|
|||
| /** | |||
| * @param null|array|string $id The ID of the account to retrieve, or an | |||
| * options array containing an `id` key. | |||
| * @param null|array|string $id the ID of the account to retrieve, or an | |||
There was a problem hiding this comment.
Surprised they don't like the leading upper case letter here, especially as the rule is about not ending with a dot
Nitpicky but not sure it looks nicer in IDEs to be honest
| @@ -3,7 +3,7 @@ | |||
| namespace Stripe; | |||
|
|
|||
| /** | |||
| * Class Account | |||
| * Class Account. | |||
There was a problem hiding this comment.
and here they want a dot. whyyyyyyyyy
|
Thanks Remi.
Probably because
I think the convention of "summaries are capitalized and have a final dot, parameter and return value descriptions are not capitalized and don't have a final dot" is the same as Javadoc. |
r? @remi-stripe @richardm-stripe
Enable more rules from the
@PhpCsFixerruleset.I will open an internal PR so that the codegen output is consistent with the updates.
I will do a last pass over the remaining disabled rules, but I think most of them will have to stay disabled because they would break our code / require significant refactoring.