Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPStan and fix settings #854

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Upgrade PHPStan and fix settings #854

merged 1 commit into from
Feb 1, 2020

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe

A few changes to PHPStan:

  • upgrade to latest version 0.12.8
  • rename phpstan.neon to phpstan.neon.dist and add phpstan.neon to .gitignore (so one can play with custom settings locally)
  • add tests/bootstrap.php to the bootstrap setting, otherwise the MOCK_URL constant is seen as missing
  • ignore the Unsafe usage of new static(). error. We're relying pretty heavily on this right now. We should be able to fix most of these once we stop relying on traits

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Feb 1, 2020
@ob-stripe ob-stripe merged commit 34409be into master Feb 1, 2020
@ob-stripe ob-stripe deleted the ob-phpstan-bootstrap branch February 1, 2020 04:48
@ob-stripe
Copy link
Contributor Author

Released as 7.23.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants