Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using PHP CS Fixer #706

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Start using PHP CS Fixer #706

merged 1 commit into from
Aug 22, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Start using PHP CS Fixer for code formatting.

@brandur-stripe
Copy link
Contributor

LGTM.

The build passes because of the dry run flag right? (Actual code formatting fixes are coming in later?)

@ob-stripe
Copy link
Contributor Author

No, we were actually already mostly compliant with the default rules and I fixed the last remaining issues ahead of time in #691.

@ob-stripe ob-stripe merged commit 7137501 into integration-v7 Aug 22, 2019
@ob-stripe ob-stripe deleted the ob-php-cs-fixer branch August 22, 2019 22:50
@brandur-stripe
Copy link
Contributor

No, we were actually already mostly compliant with the default rules and I fixed the last remaining issues ahead of time in #691.

Ah, great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants