Dont mutate native Exception class properties #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
approved these changes
Nov 12, 2018
|
LGTM as well! @ob-stripe I assume there's a reason you didn't go for the release, but if it's just that you're busy, let me know and I can take it. |
|
Ah, I waited to release this with #542, but it looks like we're going to wait a bit for that one since the API is not yet 100% set in stone. We can go ahead and release this PR in the meantime. |
|
Cool! I'm just going to release then to get it out of my inbox :) |
|
Released as 6.21.1. Thanks for the contribution @ankurk91! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #547