Add support for /v1/topups endpoints #440
Conversation
jkakar-stripe
changed the title
lib/Topup.php
Outdated
| * @property mixed $source | ||
| * @property string $statement_descriptor | ||
| * @property string $status | ||
| * @property string $balance_transaction |
There was a problem hiding this comment.
Mind alphabetizing this list (although keep $id and $object on top) and confirming that you went over it and looks correct? It looks okay to me, but I happened to notice that $description is still marked as undocumented so maybe we don't intend to expose that right away? Thanks!
There was a problem hiding this comment.
Hmm, I've updated the properties to reflect what should be exposed. I'm not sure I understand what you mean by $description being undocumented? All the fields listed now are public and should be known to users of the client.
There was a problem hiding this comment.
Thanks!
If you check the API resource in the server-side implementation, it still seems that description is marked as undocumented:
undocumented :descriptionMaybe just an oversight?
There was a problem hiding this comment.
Just to close the loop here, it looks like description is now an officially documented property.
jkakar-stripe
force-pushed
the
jkakar/topup-client
branch
from
d78923a
to
7c07bfc
Compare
|
r? @stripe/api-libraries |
|
LGTM. |
|
Released as 6.2.0. |
|
What is a topup? Nothing in the API docs about it besides a few event types. |
|
@EatonZ It's not documented yet and we just planned the feature in the libraries for now. |
|
@remi-stripe Just a heads up the documentation is still missing. |
|
@EatonZ This is totally expected. This feature is not public for now and only available in private beta for specific users. It will be released in the next few months. |
This add standard retrieve, create and update client support for the new
/v1/topupsendpoint.r? @apakulov-stripe @ccontinanza-stripe @chellman-stripe @kenneth-stripe @miguel-stripe
r? @stripe/api-libraries