Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.1] Add missing ReturnTypeWillChange #1213

Merged
merged 1 commit into from
Dec 6, 2021
Merged

[PHP 8.1] Add missing ReturnTypeWillChange #1213

merged 1 commit into from
Dec 6, 2021

Conversation

spaze
Copy link
Contributor

@spaze spaze commented Dec 1, 2021

These were originally added in #1182 (now closed) but missed in #1211 (the one replacing the former PR).

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@spaze spaze mentioned this pull request Dec 1, 2021
Closed
@spaze
Copy link
Contributor Author

spaze commented Dec 4, 2021

I've now diffed #1182 & #1211 and these should be all that were missed.

@spaze spaze changed the title Add missing ReturnTypeWillChange [PHP 8.1] Add missing ReturnTypeWillChange Dec 4, 2021
@richardm-stripe richardm-stripe merged commit e38b9dd into stripe:master Dec 6, 2021
@richardm-stripe
Copy link
Contributor

Thanks for the contribution @spaze!

@spaze spaze deleted the patch-1 branch December 6, 2021 21:28
@richardm-stripe richardm-stripe mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaze @CLAassistant @richardm-stripe