Refactor to not use static method calls

[atrauzzi]

In many applications (especially where dependency injection is used), it's preferable to not have libraries that rely on global state.

The Stripe PHP library currently takes the approach that every call is done via a static method. While it's fine to retain this as an option, it would be nice if actual objects could be leveraged.

[GrahamCampbell]

👍

[joshhornby]

👍

[Rican7]

👍

[skyzyx]

👍

[browner12]

would it be possible to maintain both as an option on the same code? I feel like that would become unmanageable quickly. would it be better to break it off into another repo, or would that be just as difficult to maintain?

maybe the better question is, should the static approach be kept, or maybe deprecated? does someone have an example where it would be difficult to instantiate actual objects?

either way 👍

[ruudk]

👍

[yurytolochko]

👍

[phillipsnick]

👍

Having fun trying to unit test my payment service because I can't mock static methods!

[armetiz]

For people trying to unit-test payment, you should make a wrapper around Stripe.

use Acme\Payment\Stripe

class Stripe
{
  static private $instance;

  public function __construct($stripeSecretKey)
  {
        if(self::$instance) {
            throw new \RuntimeException('Stripe could not be instantiate more than once. Check PHP implementation : https://github.com/stripe/stripe-php');
        }

        self::$instance = $this;

        \Stripe\Stripe::setApiKey($stripeSecretKey);
  }

  public function payAmountWithToken($token, $amount)
  {
    \Stripe\Charge::create([]); // use correct values
  }
}

I made a singleton to avoid confusion. This is a limitation but in many case you will not need to have more than one instance.

You will be able to inject your custom wrapper / mock and make your unit-test ;)

Regards.

[bakura10]

As always, for people that do not want to use static methods, you could have a look at my library ZfrStripe. It is maintained, is based on Guzzle and is definitely easier to mock and test. Having said that it may be a bit harder to use as you definitely need to inject the client when you need it instead of relying on the staticness.

[arcanedev-maroc]

👍

[adrienbrault]

😢

[KostyaChoporov]

Also will be great to make some event solution. For example I want log all requests, and i don't know hot to implement it without wrapping original requests 😢

[lunetics]

@KostyaChoporov i think it should be psr-7 compliant for that, then you could use your own client e.g. guzzle with logging.