Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark change as non-breaking #519

Merged
merged 2 commits into from
Nov 14, 2018
Merged

mark change as non-breaking #519

merged 2 commits into from
Nov 14, 2018

Conversation

avimar
Copy link
Contributor

@avimar avimar commented Nov 13, 2018

No description provided.

@remi-stripe
Copy link
Contributor

Hey @avimar! Thanks a lot for the PR and I agree that we could have made this clearer in the changelog. Would you mind tweaking the wording a bit to clarify that we aliased but still recommend moving to the new resource instead as it will likely be removed in the next major release?

Something like this maybe:

Rename FileUploads to Files. For backwards compatibility, Files is aliased to FileUploads. FileUploads is deprecated and will be removed from the next major version.

@remi-stripe
Copy link
Contributor

Thanks for the quick fix! Approved and merging!

@remi-stripe remi-stripe merged commit eca5cf3 into stripe:master Nov 14, 2018
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants