(next major) one network retry by default #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-do-one-network-retry-by-default
branch
2 times, most recently
from
e8af13d
to
8a01d2a
Compare
richardm-stripe
requested review from
a team and
anniel-stripe
and removed request for
a team
richardm-stripe
force-pushed
the
richardm-do-one-network-retry-by-default
branch
from
8a01d2a
to
d71aa88
Compare
richardm-stripe
force-pushed
the
sdk-release/next-major
branch
from
ac9661b
to
c17a9b6
Compare
richardm-stripe
force-pushed
the
richardm-do-one-network-retry-by-default
branch
from
363ae56
to
c17a9b6
Compare
|
ugh I hate git |
anniel-stripe
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the default behavior of stripe-node to perform 1 reattempt on retryable failures by default, instead of 0. Retrying is generally safe. This is the same behavior as in
stripe-go.This will improve the default experience in environments like AWS Lambda where broken connections are inevitable (fixes #1040)