Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate other Stripe infrastructure to TS #1563

Merged
merged 13 commits into from
Sep 28, 2022
Merged

Migrate other Stripe infrastructure to TS #1563

merged 13 commits into from
Sep 28, 2022

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Sep 26, 2022 •
edited
Loading

Summary

r? @kamil-stripe

Migrating remaining Stripe infrastructure files to TypeScript in a "lazy" manner. This includes the following files:

  • multiPart
  • ResourceNamespace
  • utils.js
  • Webhooks.js
  • crypto/*
  • net/*

See my comments on the .ts files for explanations of why I made a few changes.

@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch 2 times, most recently from 28d35cf to 84d3ec4 Compare September 26, 2022 16:28
anniel-stripe
anniel-stripe commented Sep 26, 2022
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
anniel-stripe
anniel-stripe commented Sep 26, 2022
View reviewed changes
src/Error.ts Outdated Show resolved Hide resolved
@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 84d3ec4 to 12af083 Compare September 26, 2022 16:37
@anniel-stripe anniel-stripe marked this pull request as ready for review September 26, 2022 16:37
@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 59823d4 to d4f0791 Compare September 26, 2022 16:38
kamil-stripe
kamil-stripe reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL :) I'm going to finish the review later.

lib/Webhooks.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/Webhooks.ts Outdated Show resolved Hide resolved
src/Webhooks.ts Show resolved Hide resolved
src/net/FetchHttpClient.ts Outdated Show resolved Hide resolved
src/net/FetchHttpClient.ts Outdated Show resolved Hide resolved
src/net/HttpClient.ts Outdated Show resolved Hide resolved
src/net/NodeHttpClient.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@anniel-stripe anniel-stripe force-pushed the anniel-migrate-remaining-infrastructure branch from 5947000 to 651024f Compare September 27, 2022 17:28
kamil-stripe
kamil-stripe reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@kamil-stripe kamil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments. LGTM otherwise.

src/utils.ts Outdated Show resolved Hide resolved
lib/ResourceNamespace.js Outdated Show resolved Hide resolved
src/crypto/SubtleCryptoProvider.ts Outdated Show resolved Hide resolved
src/crypto/SubtleCryptoProvider.ts Outdated Show resolved Hide resolved
src/net/FetchHttpClient.ts Outdated Show resolved Hide resolved
src/net/NodeHttpClient.ts Outdated Show resolved Hide resolved
anniel-stripe and others added 6 commits September 27, 2022 11:51
@anniel-stripe
Turn on alwaysStrict in tsconfig
bd50246
@anniel-stripe @kamil-stripe
Update src/net/NodeHttpClient.ts
98a9b5c 
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
@anniel-stripe @kamil-stripe
Update src/crypto/SubtleCryptoProvider.ts
cc86ba5 
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
@anniel-stripe @kamil-stripe
Update src/crypto/SubtleCryptoProvider.ts
9ce094a 
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
@anniel-stripe
Remove hasOwn alias, undo suggested commits
a2526b2
@anniel-stripe @kamil-stripe
Update src/net/FetchHttpClient.ts
2704e87 
Co-authored-by: Kamil Pajdzik <99290280+kamil-stripe@users.noreply.github.com>
@anniel-stripe anniel-stripe merged commit 5aae73c into master Sep 28, 2022
@anniel-stripe anniel-stripe deleted the anniel-migrate-remaining-infrastructure branch September 28, 2022 16:33
@shahzaibdev1 shahzaibdev1 mentioned this pull request Jun 1, 2024
Open
@IT21168222 IT21168222 mentioned this pull request Sep 10, 2024
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-stripe kamil-stripe Awaiting requested review from kamil-stripe

Assignees

@kamil-stripe kamil-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniel-stripe @kamil-stripe