Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Stripe infrastructure to Typescript #1543

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Sep 2, 2022

Summary

r? @kamil-stripe

Convert the following files to Typescript:

  • StripeMethod
  • StripeResource
  • autoPagination
  • makeRequest
  • stripe
  • Error

Testing

Validated that changes build and pass existing tests. Checked that transpiled JS files look functionally identical to the original JS. No observed changes in behavior when the library is imported and used in an external project.

@anniel-stripe anniel-stripe marked this pull request as ready for review September 6, 2022 16:59
@anniel-stripe anniel-stripe merged commit 6fb6573 into master Sep 6, 2022
@anniel-stripe anniel-stripe deleted the anniel-ts-infrastructure branch September 6, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants