Properly handle API errors with unknown error types #1357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API returns an error of a type which isn't explicitly enumerated,
StripeError.generate
tries to return aGenericError
. However, that class doesn't exist - it was deleted as part of the refactor in #672. This causes stripe-node to return an especially confusing error - it complains about the undefinedGenericError
class, instead of telling us anything useful about the actual error.This patch defines a fallback subclass of StripeError to use in these cases. (As a bonus, this means that the default error rendering will also contain the error message from the API, instead of a fixed
Unknown Error
string.)AFAICT, the only way it was possible to hit this branch is to get the oauth flow to return weird errors. Since this is served from
connect.stripe.com
instead ofapi.stripe.com
, it can return non-standard error types. It's not clear to me whether it's worth creating new error classes for these cases - for now, I've just fixed the type error.