API Updates #1265
Merged
API Updates #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
reviewed
Oct 7, 2021
There was a problem hiding this comment.
LGTM, but something seems to be up with how we're basing off of master.
PTAL @richardm-stripe ?
types/2020-08-27/Accounts.d.ts
Outdated
| /** | ||
| * The status of the Klarna payments capability of the account, or whether the account can directly process Klarna charges. | ||
| */ | ||
| klarna_payments?: Capabilities.KlarnaPayments; |
There was a problem hiding this comment.
Not sure why this is showing up in the diff - https://github.com/stripe/stripe-node/blob/1d484b23/types/2020-08-27/Accounts.d.ts#L237 this is already committed in master?
There was a problem hiding this comment.
richardm-stripe
force-pushed
the
latest-codegen
branch
from
f64ea77 to
a025616
Compare
|
@dcr-stripe rebased and fixed |
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen for openapi d0904af.
r? @dcr-stripe
cc @stripe/api-libraries
Changelog
phone_number_collectiononCheckoutSessionCreateParamsandCheckout.SessionphoneonCheckout.Session.customer_detailsPaymentMethodListParams.customerto be optionalcustomer_idon enumsRadarValueListCreateParams.item_typeandRadar.ValueList.item_typebbpos_wisepos_eon enumsTerminalReaderListParams.device_typeandTerminal.Reader.device_type