Repository navigation
Carry private-preview's CI workflow hunks on master - #2283
Merged
Merged
Conversation
private-preview's ci.yml differs from master's by exactly two additive hunks: `private-preview` in `on.push.branches`, and a `base:` input on the stripe-mock step mapping every private-preview context onto the beta spec. Because those hunks live only on private-preview, every merge of master into private-preview yields a ci.yml matching neither parent. GitHub refuses a push from a GitHub App lacking `workflows` permission when it introduces a workflow blob that does not already exist in the repository, so the codegen job's push is rejected and a human has to perform the merge by hand. Holding the hunks on master too means both sides of the merge carry the same change, the merge result is byte-identical to master's blob, and the App only ever carries an already-committed file forward. Both hunks are no-ops on master: - For a push event the workflow file comes from the pushed ref, so master's copy listing private-preview cannot affect pushes to master or beta. - The base: expression falls through to `github.base_ref || github.ref_name` for every master-side ref, which is character-identical to the default declared by stripe/openapi/actions/stripe-mock. Committed-By-Agent: claude
jar-stripe
marked this pull request as ready for review
August 28, 2026 17:41
jar-stripe
requested review from
zacchua-stripe
and removed request for
a team
August 28, 2026 17:41
xavdid
approved these changes
Aug 28, 2026
xavdid
left a comment
xavdid
left a comment
Member
There was a problem hiding this comment.
approved but i'm a little confused 😅 but willing to give it a try!
jar-stripe
enabled auto-merge (squash)
August 28, 2026 17:54
This was referenced Aug 28, 2026
jar-stripe
added a commit
that referenced
this pull request
Sep 28, 2026
* Add discriminated union serialization tests (#2260) * Add discriminated union serialization tests Tests both request-side (params → map) and response-side (JSON → object) serialization for discriminated unions, covering standalone and inline variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude * Add null assertions for non-selected DU variants Assert that when one variant is selected, the other variant fields/structs remain null in both serialization and deserialization tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Committed-By-Agent: claude * Fix response standalone DU test to use proper class hierarchy Restructure the response-side test fixtures from a flat TestColorEntity class (holding all variant fields) to a proper class hierarchy: TestColorEntity (base) -> TestRgbColorEntity / TestHsvColorEntity. Add a TestColorTypeAdapterFactory that dispatches deserialization to the correct subclass based on the `model` discriminator field, mirroring how the codegen will emit TypeAdapterFactory-based dispatch for real DUs. Update assertions to use instanceof checks and typed casts rather than checking for null fields on a flat class. Add a second test covering the HSV variant path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Committed-By-Agent: claude * fixed formatting --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Carry private-preview's CI workflow hunks on master (#2283) private-preview's ci.yml differs from master's by exactly two additive hunks: `private-preview` in `on.push.branches`, and a `base:` input on the stripe-mock step mapping every private-preview context onto the beta spec. Because those hunks live only on private-preview, every merge of master into private-preview yields a ci.yml matching neither parent. GitHub refuses a push from a GitHub App lacking `workflows` permission when it introduces a workflow blob that does not already exist in the repository, so the codegen job's push is rejected and a human has to perform the merge by hand. Holding the hunks on master too means both sides of the merge carry the same change, the merge result is byte-identical to master's blob, and the App only ever carries an already-committed file forward. Both hunks are no-ops on master: - For a push event the workflow file comes from the pushed ref, so master's copy listing private-preview cannot affect pushes to master or beta. - The base: expression falls through to `github.base_ref || github.ref_name` for every master-side ref, which is character-identical to the default declared by stripe/openapi/actions/stripe-mock. Committed-By-Agent: claude * Harden API requestor code against malicious URLs (#2284) * validate that incoming urls don't redirect requests * shorten comments * Bump version to 33.4.1 * validate that webhook secrets are non-empty (#2286) * Bump version to 33.4.2 * support related singleton objects (#2288) * Migrate changelog management to `hark` (#2289) * migrate to hark * tweak issue template * point the hark actions at master * point at the renamed check-github-links action * use the single hark/checks action in CI * use the hark checks action and rename pr_link to pr_url * record language and channel in versions.json metadata * rename versions.json to releases.json * regenerate changelogs; pad short versions * add a minimum-runtime-version recipe Committed-By-Agent: claude * add print-version-info recipe * swap from is_breaking to semver_level * trigger CI for hark v1.0.0 * add missing changefile * rename changefiles that don't adhere to new naming rules * Fix event handler account scoping (#2294) * Fix event handler account scoping Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add PR URL to changefile Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Add option to suppress Stripe notices (#2293) * Add option to suppress Stripe notices Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Add changelog entry for notice suppression Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Make Stripe notice integration test environment-independent Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> * Clarify Stripe notice suppression instructions Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> --------- Co-authored-by: codex <noreply@openai.com> * Document Stripe notice suppression (#2297) Committed-By-Agent: goose Orbit-Session-Id: d60d503e-7c8a-4aa0-89d1-37cc435afc02 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: David Brownman <1231935+xavdid@users.noreply.github.com> Co-authored-by: Zachary Chua <zacchua@stripe.com> Co-authored-by: David Brownman <xavdid@stripe.com> Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The codegen job's push to
latest-codegen-private-previewis rejected by GitHub: the master→private-preview merge produces aci.ymlthat exists nowhere in the repository, and the App performing the push has noworkflowspermission. Holding private-preview's two workflow hunks on master turns that merge into a carry-forward of an already-committed file. The commit message carries the mechanism and the argument that both hunks are inert on master.What?
private-previewtoon.push.branchesbase:input to thestripe-mockstep, copied verbatim fromprivate-previewThe resulting
ci.ymlblob is2ae769f0e56, byte-identical to what a master→private-preview merge produces today.See Also