Add dispatch_async to [STPRedirectContext handleWillForegroundNotification]
#962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intended solution to the second problem described in #957 |
…fication]` to allow `[STPRedirectContext handleURLCallback]` to be prioritized We considered some other approaches and landed on this one: Option 1: Delete `STPURLCallback` completely The downside to this approach is the host app will still get `[AppDelegate application:openURL:options:]` calls. If `STPURLCallback` was gone, the host app won't know whether or not that `[AppDelegate application:openURL:options:]` call should be ignored by their own app's routing logic. Option 2: Don't unschedule `STPURLCallback` and let the `STPRedirectContext` stay in the `STPRedirectContextStateCompleted` state The downside to this approach is the `STPRedirectContext` ends up holding a non-negligible amount of memory in order to just store the `STPRedirectContextStateCompleted` state. Option 3: Similarly to the last one, we can avoid unscheduling the `STPURLCallback` for a second or so. This is very similar to the approach we landed on but would require more significant code changes. Also the reasoning behind how much delay to have is unclear.
joeydong-stripe
force-pushed
the
joeydong/redirectContextReturn
branch
from
2d36500
to
ab8d9ce
Compare
danj-stripe
approved these changes
Jun 8, 2018
Yeah same here. Surprising to see a case where it's appropriate. |
jaimepark-stripe
pushed a commit
that referenced
this pull request
Apr 11, 2022
Expose LinkedBank type to PaymentSDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dispatch_asyncto[STPRedirectContext handleWillForegroundNotification]to allow[STPRedirectContext handleURLCallback]to be prioritizedWe considered some other approaches and landed on this one:
Option 1:
Delete
STPURLCallbackcompletelyThe downside to this approach is the host app will still get
[AppDelegate application:openURL:options:]calls. IfSTPURLCallbackwas gone, the host app won't know whether or not that[AppDelegate application:openURL:options:]call should be ignored by their own app's routing logic.Option 2:
Don't unschedule
STPURLCallbackand let theSTPRedirectContextstay in theSTPRedirectContextStateCompletedstateThe downside to this approach is the
STPRedirectContextends up holding a non-negligible amount of memory in order to just store theSTPRedirectContextStateCompletedstate.Option 3:
Similarly to the last one, we can avoid unscheduling the
STPURLCallbackfor a second or so.This is very similar to the approach we landed on but would require more significant code changes. Also the reasoning behind how much delay to have is unclear.