-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpers for EPS and Multibanco source creation #961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
}]; | ||
[self waitForExpectationsWithTimeout:5.0f handler:nil]; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think multibanco needs a functional test too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right slipped my mind
r? @danj-stripe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* 32 points of padding between FormElement and the error label/Buy button * Center text field / dropdown / phone number * Update snapshot tests * Update snapshot tests * Update snapshot tests
https://stripe.com/docs/sources/eps
https://stripe.com/docs/sources/multibanco
I generally searched for "P24" and verified we updated anywhere that's referenced to include EPS and Multibanco