Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for EPS and Multibanco source creation #961

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

joeydong-stripe
Copy link
Contributor

@joeydong-stripe joeydong-stripe commented Jun 7, 2018

https://stripe.com/docs/sources/eps

https://stripe.com/docs/sources/multibanco

I generally searched for "P24" and verified we updated anywhere that's referenced to include EPS and Multibanco

@joeydong-stripe
Copy link
Contributor Author

r? @danj-stripe / @csabol-stripe

Copy link
Contributor

@csabol-stripe csabol-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

}];
[self waitForExpectationsWithTimeout:5.0f handler:nil];
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think multibanco needs a functional test too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right slipped my mind

@joeydong-stripe
Copy link
Contributor Author

r? @danj-stripe

Copy link
Contributor

@danj-stripe danj-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@joeydong-stripe joeydong-stripe merged commit b851892 into master Jun 8, 2018
jaimepark-stripe pushed a commit that referenced this pull request Apr 11, 2022
* 32 points of padding between FormElement and the error label/Buy button

* Center text field / dropdown / phone number

* Update snapshot tests

* Update snapshot tests

* Update snapshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants