Always recreate loadingPromise when calling retryLoading #863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @danj-stripe
Calling
retryLoading
currently does nothing if the promise has been completed with a value. The method was initially intended for use when PaymentContext's initial load fails, but you would also expect it to be useful for triggering a refresh of the stored customer object:I can't think of any unintended side effects from this change. The method is only called once internally, in the
STPPaymentContext
initialization path. Apps that use this method to recover from initial loading errors won't be affected by the change.