PaymentSheet now always shows Apple Pay as a button above the saved P… #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ms list, instead of inside the list. Previously, it only showed as a button if link was also shown as a button.
| @@ -37,6 +37,7 @@ class PaymentSheetSnapshotTests: STPSnapshotTestCase { | |||
| var runAgainstLiveService: Bool = false | |||
| override func setUp() { | |||
| super.setUp() | |||
| // recordMode = true | |||
There was a problem hiding this comment.
Note that you can rerun these by choosing the "AllStripeFrameworks-RecordMode" scheme and running the test, you don't need to add this line anymore
davidme-stripe
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Ms list, instead of inside the list. Previously, it only showed as a button if link was also shown as a button.
Summary
Before:
After:
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-1539
Testing
TBD
Changelog