Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OXXO Payment Method #1592

Merged
merged 19 commits into from
Oct 13, 2020
Merged

Add OXXO Payment Method #1592

merged 19 commits into from
Oct 13, 2020

Conversation

pololi-stripe
Copy link
Contributor

@pololi-stripe pololi-stripe commented Jun 19, 2020 •
edited
Loading

Summary

Add OXXO Payment Method

Motivation

To support OXXO payment method in iOS SDK.

Testing

  • Functional test STPPaymentMethodOXXOParamsTests and STPPaymentMethodOXXOTests
  • Non-card example
    Xnip2020-06-23_23-12-27
    Xnip2020-06-23_23-12-04
    Xnip2020-06-23_23-12-12
    Xnip2020-06-23_23-12-20

@pololi-stripe pololi-stripe marked this pull request as ready for review June 19, 2020 18:27
@pololi-stripe pololi-stripe force-pushed the pololi/add-oxxo-payment-method branch from e63379a to 495486c Compare June 24, 2020 18:06
@pololi-stripe pololi-stripe force-pushed the pololi/add-oxxo-payment-method branch from 495486c to ed75a71 Compare June 24, 2020 19:00
@pololi-stripe
Copy link
Contributor Author

The test failed on CI because OXXO related tests requires beta header. I've ran those tests locally with override beta version.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davidme-stripe
Copy link
Contributor

I merged this to the latest, cleaned up the next_action changes since the beta, and tested against Non-Card Payment Examples. @csabol-stripe or @yuki-stripe, can you give it another review?

@pololi-stripe
Copy link
Contributor Author

💯 Thank you ❤️ !
I'll assign back to you to merge it. Thank you! @davidme-stripe

@davidme-stripe davidme-stripe merged commit 595ab66 into master Oct 13, 2020
@davidme-stripe davidme-stripe deleted the pololi/add-oxxo-payment-method branch October 13, 2020 23:47
@carlosdelamora
Copy link

I am curious about how the flow will work. Is there a place where you are writing about it?

@davidme-stripe
Copy link
Contributor

Hey @carlosdelamora! We've added some docs for using OXXO on iOS: https://stripe.com/docs/payments/oxxo/accept-a-payment#ios

kgaidis-stripe added a commit that referenced this pull request Dec 2, 2022
@kgaidis-stripe
Merge pull request #1592 from stripe-ios/kg-renameauth
9f92205 
Financial Connections: renamed instances of AuthorizationSession to AuthSession.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-stripe yuki-stripe yuki-stripe approved these changes

@csabol-stripe csabol-stripe Awaiting requested review from csabol-stripe

Assignees

@davidme-stripe davidme-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pololi-stripe @CLAassistant @davidme-stripe @carlosdelamora @yuki-stripe @Killionn55 @csabol-stripe