-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STPApplePayContext #1499
Merged
Merged
STPApplePayContext #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
requested review from
bg-stripe,
csabol-stripe and
davidme-stripe
February 21, 2020 00:09
…ret} to STPPaymentIntentConfirmationMethod{Automatic, Manual}
yuki-stripe
force-pushed
the
yuki/auto-apple-pay
branch
from
February 27, 2020 00:04
c2da457
to
c06959a
Compare
yuki-stripe
force-pushed
the
yuki/auto-apple-pay
branch
from
February 27, 2020 01:13
c06959a
to
577e15b
Compare
…re done as a safeguard
csabol-stripe
approved these changes
Mar 6, 2020
csabol-stripe
approved these changes
Mar 11, 2020
csabol-stripe
approved these changes
Mar 20, 2020
csabol-stripe
approved these changes
Apr 2, 2020
davidme-stripe
added a commit
that referenced
this pull request
Oct 14, 2022
[23] Update README files for SDK 23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A helper class that encapsulates
PKPaymentAuthorizationViewController
/PKPaymentAuthorizationViewControllerDelegate
and implements the boilerplate, state management, and tricky cancel/timeout logic for the user.TODO in future PR
[] Use this in PaymentContext
Handles:
Doesn't handle:
PKPaymentAuthorizationViewControllerDelegate
methods e.g. add a surcharge indidSelectPaymentMethod
Motivation
https://paper.dropbox.com/doc/iOS-SDK-Apple-Pay-Wrapper-Proposal--Auyzacgn1O3XTdFO4U8DepqCAg-ter8eunlOgf9cEw9szQxm
Testing
See unit and functional tests