Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STPApplePayContext #1499

Merged
merged 18 commits into from
Apr 2, 2020
Merged

STPApplePayContext #1499

merged 18 commits into from
Apr 2, 2020

Conversation

yuki-stripe
Copy link
Collaborator

@yuki-stripe yuki-stripe commented Feb 21, 2020

Summary

A helper class that encapsulates PKPaymentAuthorizationViewController/ PKPaymentAuthorizationViewControllerDelegate and implements the boilerplate, state management, and tricky cancel/timeout logic for the user.

TODO in future PR
[] Use this in PaymentContext

Handles:

Doesn't handle:

  • SetupIntents
  • If you want to respond to other PKPaymentAuthorizationViewControllerDelegate methods e.g. add a surcharge in didSelectPaymentMethod

Motivation

https://paper.dropbox.com/doc/iOS-SDK-Apple-Pay-Wrapper-Proposal--Auyzacgn1O3XTdFO4U8DepqCAg-ter8eunlOgf9cEw9szQxm

Testing

See unit and functional tests

@yuki-stripe yuki-stripe changed the title [WIP] STPApplePayContext STPApplePayContext Feb 27, 2020
Stripe/PublicHeaders/STPApplePayContext.h Show resolved Hide resolved
Stripe/PublicHeaders/STPApplePayContext.h Outdated Show resolved Hide resolved
Stripe/STPApplePayContext.m Show resolved Hide resolved
Stripe/STPApplePayContext.m Outdated Show resolved Hide resolved
Stripe/STPApplePayContext.m Outdated Show resolved Hide resolved
Stripe/STPApplePayContext.m Show resolved Hide resolved
Stripe/STPApplePayContext.m Outdated Show resolved Hide resolved
Stripe/STPApplePayContext.m Outdated Show resolved Hide resolved
@stripe-ci stripe-ci removed the approved label Apr 1, 2020
@yuki-stripe yuki-stripe merged commit 48190cd into master Apr 2, 2020
@yuki-stripe yuki-stripe deleted the yuki/auto-apple-pay branch April 2, 2020 21:51
davidme-stripe added a commit that referenced this pull request Oct 14, 2022
[23] Update README files for SDK 23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants