Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set address when creating Apple Pay PaymentMethods #1334

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

davidme-stripe
Copy link
Contributor

Summary

We should set the billing address from the Apple Pay PKPayment when creating a PaymentMethod.

Motivation

We used to do this for Sources, but we didn't do it for PaymentMethods. Fixes #1331.

Testing

Ran Apple Pay transaction on device.

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thank you

@davidme-stripe davidme-stripe merged commit a5ec621 into master Aug 29, 2019
@davidme-stripe davidme-stripe deleted the davidme/apple-pay-address branch August 29, 2019 22:48
ramont-stripe pushed a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set billingDetails with createPaymentMethodWithPayment
3 participants