Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PaymentIntents support #1038

Merged
merged 16 commits into from
Nov 14, 2018
Merged

Update PaymentIntents support #1038

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
12a23a0
Remove `PaymentIntent.returnUrl` property
danj-stripe Nov 6, 2018
0e7501c
Add (empty) classes for next_source_action values
danj-stripe Nov 7, 2018
98a68e7
Fill out implementation of STPPaymentIntentSourceActionAuthorizeWithURL
danj-stripe Nov 7, 2018
d8cfcab
Add enum for nextSourceAction.type
danj-stripe Nov 7, 2018
a842822
Fill out implementation of STPPaymentIntentSourceAction
danj-stripe Nov 7, 2018
975f56f
Add STPPaymentIntentSourceAction to STPPaymentIntent
danj-stripe Nov 7, 2018
a211cd6
Update STPPaymentIntent tests, and JSON for fixture
danj-stripe Nov 7, 2018
8f8de96
Adding test for new enum value from string
danj-stripe Nov 7, 2018
40ac1f4
Add test for decoding `STPPaymentIntentSourceAction`
danj-stripe Nov 7, 2018
52f6606
Convert enum value to a string, instead of using `type` from the server
danj-stripe Nov 7, 2018
4adcc95
Update disabled functional test for confirming to make sure the retur…
danj-stripe Nov 7, 2018
b4ccf91
Use `STPPaymentIntentSourceActionAuthorizeWithURL.returnURL` in `STPR…
danj-stripe Nov 8, 2018
eba2751
Update MIGRATING for removal of `STPPaymentIntent.returnUrl`
danj-stripe Nov 8, 2018
04d4d10
Use SDK's enum value instead of server's string constant in documenta…
danj-stripe Nov 8, 2018
40e9acf
Use dict, not response, while decoding.
danj-stripe Nov 8, 2018
09614b1
Fix copy/paste error in failing test
danj-stripe Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix copy/paste error in failing test
  • Loading branch information
@danj-stripe
danj-stripe committed Nov 13, 2018
commit 09614b1359039e69476afaeb0f7e9e63f5479d8f
2 changes: 1 addition & 1 deletion Tests/Tests/STPPaymentIntentTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ - (void)testConfirmationMethodFromString {
- (void)testSourceActionFromString {
XCTAssertEqual([STPPaymentIntent sourceActionTypeFromString:@"authorize_with_url"],
STPPaymentIntentSourceActionTypeAuthorizeWithURL);
XCTAssertEqual([STPPaymentIntent confirmationMethodFromString:@"AUTHORIZE_WITH_URL"],
XCTAssertEqual([STPPaymentIntent sourceActionTypeFromString:@"AUTHORIZE_WITH_URL"],
STPPaymentIntentSourceActionTypeAuthorizeWithURL);

XCTAssertEqual([STPPaymentIntent confirmationMethodFromString:@"garbage"],
Expand Down