Update STPPaymentIntentFunctionalTest.testConfirmCanceledPaymentIntentFails
#1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntFails` Making it slightly less brittle to server-side changes. Previous test was failing due to the addition of `requires_capture` in the list of acceptable statuses. This is still asserting on a server-side string that might change, but I want some way to make sure the error is the one I expect.
csabol-stripe
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making it slightly less brittle to server-side changes. Previous test was failing
due to the addition of
requires_capturein the list of acceptable statuses.This is still asserting on a server-side string that might change, but I want some way
to make sure the error is the one I expect.
Motivation
Test is broken on master.
Testing
Ran the tests locally, CI will run them too