Skip to content

Commit

Permalink
Update how we leave a comment
Browse files Browse the repository at this point in the history
  • Loading branch information
porter-stripe committed Apr 12, 2024
1 parent 0d101d3 commit 293139d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/verify-public-interface.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ jobs:

- uses: peter-evans/create-or-update-comment@v1
id: create-update-comment
if: steps.check-api.outputs.new_apis_detected == 'yes'
if: steps.public-api-diff.outputs.diff
with:
body: |
⚠️ Change in public APIs detected:
```diff
${{ env.API_DIFF }}
${{ steps.public-api-diff.outputs.diff }}
```
Consider the following:
Expand All @@ -116,5 +116,5 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Fail if not acknowledged
if: "steps.check-api.outputs.new_apis_detected == 'yes' && !contains(github.event.pull_request.labels.*.name, 'adds public API')"
if: "steps.public-api-diff.outputs.diff && !contains(github.event.pull_request.labels.*.name, 'adds public API')"
run: exit 1

0 comments on commit 293139d

Please sign in to comment.