update PaymentSource.MarshalJSON to serialize bank accounts too #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. Thanks for adding that bonus test too! Just out of curiosity, what exactly are you using this for? I was a little surprised to find that it even existed, and had to dig back for context to #88 to see why. |
|
Released as 29.0.1. |
|
Thanks for the merge. My situation seems similar to #88. I'm building a Gmail Add-on for Stripe. In my case, the client is Gmail and requests are proxied through my servers rather than hitting Stripe directly. I noticed that the response from the Stripe API was correct, but became corrupt as soon as the objects were re-serialized on the way back to the client. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.10101 to 0.5.10109. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes serialization for
PaymentSourceBankAccount.PaymentSourcehas aMarshalJSONimplementation with custom behavior based on type but there was no implementation for typePaymentSourceBankAccountso bank accounts were being serialized asnull.