Product and plan support #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantera-stripe
force-pushed
the
pantera-product-and-plan-support
branch
from
9bd347c
to
c254932
Compare
pantera-stripe
force-pushed
the
pantera-product-and-plan-support
branch
from
c254932
to
9bb1c27
Compare
pantera-stripe
commented
Feb 14, 2018
| @@ -23,7 +23,7 @@ cache: | |||
|
|
|||
| env: | |||
| global: | |||
| - STRIPE_MOCK_VERSION=0.4.0 | |||
| - STRIPE_MOCK_VERSION=0.7.0 | |||
There was a problem hiding this comment.
This and the version bump are the largest changes from the original PR.
pantera-stripe
commented
Feb 14, 2018
| @@ -17,7 +17,7 @@ func TestEphemeralKeyDel(t *testing.T) { | |||
| func TestEphemeralKeyNew(t *testing.T) { | |||
| key, err := New(&stripe.EphemeralKeyParams{ | |||
| Customer: "cus_123", | |||
| StripeVersion: "2017-05-25", | |||
| StripeVersion: "2018-02-06", | |||
There was a problem hiding this comment.
Figured I should bump this to the latest API version. Plan and Product updates reflect these changes with the removal of name and statement_descriptor from Plan.
|
Also... |
|
LGTM! |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.10096 to 0.5.10109. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credit goes to @jhoon-stripe for the original PR: #496
I just rebased and resolved conflicts. From the original PR:
Summary
This PR implements upcoming changes to the way in which plan objects are created in the Stripe API. Specifically, it:
r? @brandur-stripe @tmaxwell-stripe
cc @stripe/api-libraries