Remove Charge.Token #458
Merged
Remove Charge.Token #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately I forgot about this one before releasing, but it doesn't appear that `Token` on `ChargeParams` is used anywhere and I can't find it in any of the charge-related documentation on the API reference.
brandur-stripe
force-pushed
the
brandur-remove-charge-token
branch
from
e0ba68b
to
f9a02c3
Compare
|
LGTM. I have never heard of this parameter before and it's unlikely to break anyone. |
|
Thanks Remi. |
|
Alright, just for good hygiene, released this as 27.0.0 (even though it's not likely to break anyone). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I forgot about this one before releasing, but it doesn't
appear that
TokenonChargeParamsis used anywhere and I can't findit in any of the charge-related documentation on the API reference.
@remi-stripe Thoughts?