Start using Go Modules #1061
Merged
Start using Go Modules #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As suggested by Remi, just pushed one more commit that brings this back to v70 so that we can test that our release script works properly when the time comes. |
remi-stripe
force-pushed
the
integration-v71
branch
from
8d70710
to
28c24cf
Compare
remi-stripe
force-pushed
the
brandur-go-modules
branch
from
df588fe
to
d4fa5a2
Compare
Similar to the original implementation for Go Modules in #712, here we add a `go.mod` and `go.sum`, then proceed to use Go Modules style import paths everywhere that include the current major revision. Unfortunately, this may still cause trouble for Dep users who are trying to upgrade stripe-go, but the project's now had two years to help its users with basic Go Module awareness, and has chosen not to do so. It's received no commits of any kind since August 2019, and therefore would be considered unmaintained by most definitions. Elsewhere, Go Modules now seem to be the only and obvious way forward, so we're likely to see more and more users on them. `scripts/check_api_clients/main.go` is also updated to be smarter about breaking down package paths which may now include the major. [1] golang/dep#1963
Move back down to current major version so that we can test that our release script will bump it to v71 properly when the time comes.
remi-stripe
force-pushed
the
brandur-go-modules
branch
from
d4fa5a2
to
e3934e7
Compare
|
This was rebased on the latest integration-v71 and we can now merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the original implementation for Go Modules in #712, here we
add a
go.modandgo.sum, then proceed to use Go Modules styleimport paths everywhere that include the current major revision.
Unfortunately, this may still cause trouble for Dep users who are trying
to upgrade stripe-go, but the project's now had two years to help its
users with basic Go Module awareness, and has chosen not to do so. It's
received no commits of any kind since August 2019, and therefore would
be considered unmaintained by most definitions. Elsewhere, Go Modules
now seem to be the only and obvious way forward, so we're likely to see
more and more users on them.
scripts/check_api_clients/main.gois also updated to be smarter aboutbreaking down package paths which may now include the major.
Caveats:
Go Coverage in tip is broken, and it wasn't immediately obvious to me
why. We can probably get this fixed at our leisure though because it's
marked as an allowed failure in the build.
We still need a solution to put the major version import into the API
reference docs. I can probably figure something out there next week.
r? @remi-stripe
cc @stripe/api-libraries
[1] golang/dep#1963
Note: Targets the branch in #1055 for V71 integration.