Separate the default StripeConfiguration.StripeClient from feature-full StripeClient class, and add telemetry string to StripeClient #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport the default StripeConfiguration.StripeClient added defaultUsage construction parameter to LiveApiRequestor to let callers specify telemetry usage strings to include in every request modified StripeConfiguration.BuildDefaultStripeClient to build a DefualtStripeClient instead of StripeClient added tests to StripeClientTest and StripeConfigurationTest to verify the changes refactored BaseStripeTest to ensure we let StripeClient create the LiveApiRequestor (with the correct default usage)
helenye-stripe
approved these changes
Jul 22, 2025
This was referenced Jul 31, 2025
This was referenced Aug 17, 2025
This was referenced Aug 25, 2025
This was referenced Sep 4, 2025
This was referenced Sep 11, 2025
This was referenced Sep 25, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Stripe.NET supports two different service usage patterns: direct Service class construction, and accessing services via StripeClient. We want to be able to differentiate these patterns in our client telemetry.
What?
See Also
Changelog
StripeClientservice accessors