Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #2455

Merged
merged 4 commits into from
Apr 19, 2022
Merged

API Updates #2455

merged 4 commits into from
Apr 19, 2022

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Apr 14, 2022

Codegen for openapi a8928d0.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add support for new resources FundingInstructions and Terminal.Configuration
  • Add support for CreateFundingInstructions method on resource Customer
  • Add support for CustomerBalance on ChargePaymentMethodDetails, PaymentIntentPaymentMethodDataOptions, PaymentIntentPaymentMethodOptionsOptions, PaymentIntentPaymentMethodOptions, PaymentMethodCreateOptions, and PaymentMethod
  • Add support for CashBalance on CustomerCreateOptions and CustomerUpdateOptions
  • Add support for AmountDetails on PaymentIntent
  • Add support for DisplayBankTransferInstructions on PaymentIntentNextAction
  • Add support for ConfigurationOverrides on TerminalLocationCreateOptions, TerminalLocationUpdateOptions, and TerminalLocation

@@ -36,6 +36,16 @@ public virtual Task<Customer> CreateAsync(CustomerCreateOptions options, Request
return this.CreateEntityAsync(options, requestOptions, cancellationToken);
}

public virtual FundingInstructions CreateFundingInstructions(string id, CustomerCreateFundingInstructionsOptions options = null, RequestOptions requestOptions = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to re-add the FundingInstructions type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed!

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly looks good, just one question.

@@ -0,0 +1 @@
// File generated from our OpenAPI spec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip this file?

@richardm-stripe richardm-stripe merged commit 1df2301 into master Apr 19, 2022
@richardm-stripe richardm-stripe deleted the latest-codegen branch April 20, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants