Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net60 and netcoreapp3.1 targets #2411

Merged
merged 6 commits into from
Feb 6, 2022
Merged

Conversation

jon-armen
Copy link
Contributor

@jon-armen jon-armen commented Jan 4, 2022

See #2410
Fixes #2418

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2022

CLA assistant check
All committers have signed the CLA.

@k3davis
Copy link

k3davis commented Jan 6, 2022

I hope this can be merged soon! Appears to be just a missing framework install on your CI platform...?

@jon-armen
Copy link
Contributor Author

I hope this can be merged soon! Appears to be just a missing framework install on your CI platform...?

I didn't have a chance to follow up on the CI side, I had just gotten the code running locally. Thanks for pointing out, I'll see if the repo has the related files that would need to be updated to get that part working.

@jon-armen
Copy link
Contributor Author

@jchen293 , what would the timeline be for this being merged in?

@jon-armen jon-armen mentioned this pull request Feb 3, 2022
@k3davis
Copy link

k3davis commented Feb 3, 2022

Pretty please merge this... :)

@jon-armen
Copy link
Contributor Author

@remi-stripe , @richardm-stripe , what would be the timeline for this to be merged?

@richardm-stripe richardm-stripe merged commit 9a4f233 into stripe:master Feb 6, 2022
@richardm-stripe
Copy link
Contributor

Hello, thank you for the contribution @jon-armen. Very sorry for the delay on this, it has been released in v39.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 support
5 participants