Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a couple directories and files to follow convention #1911

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

cjavilla-stripe
Copy link
Contributor

Renaming a couple directories to follow a convention that we'll use for autogen this has no functional impact on the library, just moving things around so it's more standardized.

r? @remi-stripe
cc @stripe/api-libraries

@ob-stripe
Copy link
Contributor

Nit, but I think we should special case Balance and ThreeDSecure to not be pluralized.

@cjavilla-stripe
Copy link
Contributor Author

Okay will do

@cjavilla-stripe
Copy link
Contributor Author

Updated Balance and ThreeDSecure to be singular.

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ob-stripe ob-stripe merged commit 9c26cc2 into master Feb 7, 2020
@ob-stripe ob-stripe deleted the cjavilla/rename-directories branch February 7, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants