Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ReportRun.SucceededAt nullable #1824

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Make ReportRun.SucceededAt nullable #1824

merged 1 commit into from
Oct 28, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Make ReportRun.SucceededAt nullable.

Fixes #1823.

remi-stripe
remi-stripe approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I say I hate nullable fields in our API recently? :p

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Oct 28, 2019
@ob-stripe ob-stripe merged commit 8096173 into master Oct 28, 2019
@ob-stripe ob-stripe deleted the ob-fix-1823 branch October 28, 2019 19:49
@ob-stripe
Copy link
Contributor Author

Released as 32.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Invalid response object from API" exception when creating a Report Run
3 participants
@ob-stripe @remi-stripe @stripe-ci