Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Last4 in AU BECS Source and Deprecating Last3 #1789

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Add Last4 in AU BECS Source and Deprecating Last3 #1789

merged 2 commits into from
Sep 26, 2019

Conversation

shengwei-stripe
Copy link
Contributor

@remi-stripe @ob-stripe
This is to update AUDD SourceAuBecsDebit Parameter. Deprecating Last3 and Add Last4
Related Pull request (stripe/stripe-go#952)

cc @stripe/api-libraries

@shengwei-stripe shengwei-stripe mentioned this pull request Sep 20, 2019
Merged
remi-stripe
remi-stripe requested changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you're still not adding SourceMandate at all as the resource, only params. Is that expected? I also don't see it in java, but it's partially in go.

src/Stripe.net/Entities/Sources/SourceAuBecsDebit.cs Show resolved Hide resolved
@shengwei-stripe
Copy link
Contributor Author

Also you're still not adding SourceMandate at all as the resource, only params. Is that expected? I also don't see it in java, but it's partially in go.

Yes @remi-stripe , I did not see SourceMandate use anywhere as API resource. The SourceMandate was there in Golang before. It was tested for a very old API I think

@remi-stripe remi-stripe merged commit c6e14c4 into stripe:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@shengwei-stripe shengwei-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shengwei-stripe @remi-stripe @stripe-ci