Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ChargePaymentMethodDetailsCard.Moto nullable #1750

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Make ChargePaymentMethodDetailsCard.Moto nullable #1750

merged 1 commit into from
Aug 16, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Fixes #1749.

@ob-stripe ob-stripe changed the title Make ChargePaymentMethodDetailsCard.Moto nullable Make ChargePaymentMethodDetailsCard.Moto nullable Aug 16, 2019
remi-stripe
remi-stripe approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing my mistake.

I honestly think it's time to make all those fields nullable. Even if we autogen, things will stop being nullable or vice-versa and we will keep breaking users.

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Aug 16, 2019
@ob-stripe ob-stripe merged commit 21d349f into master Aug 16, 2019
@ob-stripe ob-stripe deleted the ob-fix-1749 branch August 16, 2019 16:49
@ob-stripe
Copy link
Contributor Author

Released as 28.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook fails to parse
3 participants
@ob-stripe @remi-stripe @stripe-ci